Skip to content

Fix apt 404s in Docker #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2016
Merged

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Nov 12, 2016

apt update and apt install should be in the same Docker RUN statement, otherwise apt update will be cached and apt install will 404 if a package no longer exists.

@japaric
Copy link
Member

japaric commented Nov 12, 2016

Ohh this makes sense. I have seen these 404 errors locally.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2016

📌 Commit ba7df31 has been approved by japaric

@bors
Copy link
Contributor

bors commented Nov 12, 2016

⌛ Testing commit ba7df31 with merge 37d77de...

bors added a commit that referenced this pull request Nov 12, 2016
Fix apt 404s in Docker

`apt update` and `apt install` should be in the same Docker RUN statement, otherwise `apt update` will be cached and `apt install` will 404 if a package no longer exists.
`apt update` and `apt install` should be in the same Docker RUN statement, otherwise `apt update` will be cached and `apt install` will 404 if a package no longer exists.
@mattico
Copy link
Contributor Author

mattico commented Nov 12, 2016

Forgot a backslash, but the other two travis failures don't look relavent.

qemu-user-static
RUN apt-get install -y --no-install-recommends qemu-system-mips
qemu-user-static \
apt-get install -y --no-install-recommends qemu-system-mips
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a && between the qemu-user-static and the apt-get.

@japaric
Copy link
Member

japaric commented Nov 12, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2016

📌 Commit e2fc5a0 has been approved by japaric

bors added a commit that referenced this pull request Nov 13, 2016
Fix apt 404s in Docker

`apt update` and `apt install` should be in the same Docker RUN statement, otherwise `apt update` will be cached and `apt install` will 404 if a package no longer exists.
@bors
Copy link
Contributor

bors commented Nov 13, 2016

⌛ Testing commit e2fc5a0 with merge e12d8c9...

@bors
Copy link
Contributor

bors commented Nov 13, 2016

💥 Test timed out

@japaric
Copy link
Member

japaric commented Nov 13, 2016

Tests passed. Merging.

@japaric japaric merged commit ab0693d into rust-lang:master Nov 13, 2016
@mattico mattico deleted the fix-docker-apt-404 branch September 19, 2017 04:06
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
117: implement cosh r=japaric a=kirch7

`cosh(f64)` implemented. I had to implement `__expo2(f64)` also.

Co-authored-by: Cássio Kirch <[email protected]>
Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants