Skip to content

test the mips64 targets #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2016
Merged

test the mips64 targets #105

merged 1 commit into from
Oct 19, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Oct 15, 2016

These should be all the required changes I think but libloading can't be cross compiled for these new targets:

error: failed to run custom build command for `libloading v0.3.1`
process didn't exit successfully: `/target/debug/build/libloading-07147fe7fffab0b2/build-script-build`(exit code: 101)
--- stderr
thread 'main' panicked at 'could not get target info: TargetNotFound', ../src/libcore/result.rs:799
note: Run with `RUST_BACKTRACE=1` for a backtrace.

I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed.

cc @alexcrichton

@japaric
Copy link
Member Author

japaric commented Oct 15, 2016

More targets became available today but I don't think it makes much sense to test the arm-musl targets because we are already testing the arm-gnu ones and we'd be testing the same arch again.

It'd be nice to test the s390x target but QEMU crashes when running s390x binaries like it did with the ppc64le target and we can't apply the QEMU_CPU trick because there are no CPUs to choose from, in the case of qemu-s390x.

@alexcrichton
Copy link
Member

r+ from me!

@japaric
Copy link
Member Author

japaric commented Oct 17, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 17, 2016

📌 Commit 86e3b95 has been approved by japaric

@bors
Copy link
Contributor

bors commented Oct 17, 2016

⌛ Testing commit 86e3b95 with merge 454b1cf...

bors added a commit that referenced this pull request Oct 17, 2016
test the mips64 targets

These should be all the required changes I think but libloading can't be cross compiled for these new targets:

```
error: failed to run custom build command for `libloading v0.3.1`
process didn't exit successfully: `/target/debug/build/libloading-07147fe7fffab0b2/build-script-build`(exit code: 101)
--- stderr
thread 'main' panicked at 'could not get target info: TargetNotFound', ../src/libcore/result.rs:799
note: Run with `RUST_BACKTRACE=1` for a backtrace.
```

I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed.

cc @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 17, 2016

💔 Test failed - travis

@japaric
Copy link
Member Author

japaric commented Oct 19, 2016

error[E0514]: found crate `std` compiled by an incompatible version of rustc

  |

  = help: please recompile that crate using this compiler (rustc 1.14.0-nightly (98a3502da 2016-10-15))

  = note: crate `std` path #1: /rust/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-6eb85298.rlib compiled by "rustc 1.14.0-nightly (6dc035ed9 2016-10-15)"

  = note: crate `std` path #2: /rust/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-6eb85298.so compiled by "rustc 1.14.0-nightly (6dc035ed9 2016-10-15)"

error: aborting due to previous error

I think this was just a rustup hiccup (it installed the wrong std?)

@bors retry

@bors
Copy link
Contributor

bors commented Oct 19, 2016

⌛ Testing commit 86e3b95 with merge 77ff499...

bors added a commit that referenced this pull request Oct 19, 2016
test the mips64 targets

These should be all the required changes I think but libloading can't be cross compiled for these new targets:

```
error: failed to run custom build command for `libloading v0.3.1`
process didn't exit successfully: `/target/debug/build/libloading-07147fe7fffab0b2/build-script-build`(exit code: 101)
--- stderr
thread 'main' panicked at 'could not get target info: TargetNotFound', ../src/libcore/result.rs:799
note: Run with `RUST_BACKTRACE=1` for a backtrace.
```

I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed.

cc @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 19, 2016

☀️ Test successful - status-appveyor, travis
Approved by: japaric
Pushing 77ff499 to master...

@bors bors merged commit 86e3b95 into rust-lang:master Oct 19, 2016
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
105: acosf asinf atanf expm1f sinf tanf r=japaric a=japaric

rebased version of rust-lang#97
closes rust-lang#97
cc @burrbull

Co-authored-by: Andrey Zgarbul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants