-
Notifications
You must be signed in to change notification settings - Fork 230
test the mips64 targets #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More targets became available today but I don't think it makes much sense to test the arm-musl targets because we are already testing the arm-gnu ones and we'd be testing the same arch again. It'd be nice to test the s390x target but QEMU crashes when running s390x binaries like it did with the ppc64le target and we can't apply the QEMU_CPU trick because there are no CPUs to choose from, in the case of qemu-s390x. |
r+ from me! |
@bors r+ |
📌 Commit 86e3b95 has been approved by |
test the mips64 targets These should be all the required changes I think but libloading can't be cross compiled for these new targets: ``` error: failed to run custom build command for `libloading v0.3.1` process didn't exit successfully: `/target/debug/build/libloading-07147fe7fffab0b2/build-script-build`(exit code: 101) --- stderr thread 'main' panicked at 'could not get target info: TargetNotFound', ../src/libcore/result.rs:799 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed. cc @alexcrichton
💔 Test failed - travis |
I think this was just a rustup hiccup (it installed the wrong std?) @bors retry |
test the mips64 targets These should be all the required changes I think but libloading can't be cross compiled for these new targets: ``` error: failed to run custom build command for `libloading v0.3.1` process didn't exit successfully: `/target/debug/build/libloading-07147fe7fffab0b2/build-script-build`(exit code: 101) --- stderr thread 'main' panicked at 'could not get target info: TargetNotFound', ../src/libcore/result.rs:799 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed. cc @alexcrichton
☀️ Test successful - status-appveyor, travis |
105: acosf asinf atanf expm1f sinf tanf r=japaric a=japaric rebased version of rust-lang#97 closes rust-lang#97 cc @burrbull Co-authored-by: Andrey Zgarbul <[email protected]>
These should be all the required changes I think but libloading can't be cross compiled for these new targets:
I've openend nagisa/rust_libloading#19 to track that. Wel'll have to wait until that's fixed.
cc @alexcrichton