Skip to content

Refactor Float implementation #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattico opened this issue Jun 25, 2017 · 1 comment
Closed

Refactor Float implementation #169

mattico opened this issue Jun 25, 2017 · 1 comment

Comments

@mattico
Copy link
Contributor

mattico commented Jun 25, 2017 •
edited
Loading

#166 refactored the integer intrinsics by:

  • Adding wrapping_ functions to the Int trait, removing the need for lots of Wrapping(x) and x.0
  • Using traits to implement the various operations rather than using macros

These can both be applied to some extent to the floating point implementation.
@mattico
Copy link
Contributor Author

mattico commented Jun 25, 2017

I created this issue as a reminder for myself, so I'll get around to doing this eventually.

@mattico mattico mentioned this issue Jun 26, 2017
Closed
@est31 est31 mentioned this issue Sep 14, 2017
Merged
bors added a commit that referenced this issue Sep 14, 2017
@bors
Auto merge of #192 - est31:master, r=alexcrichton
35dec6b 
Refactor float implementation

Refactors the float implementation. Fixes #169. Parts of the PR were inspired a previous PR by @mattico .
@bors bors closed this as completed in #192 Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattico