Skip to content

Rust 1.23 release #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2018
Merged

Rust 1.23 release #223

merged 3 commits into from
Jan 4, 2018

Conversation

steveklabnik
Copy link
Member

No description provided.

@steveklabnik
Copy link
Member Author

r? @rust-lang/core

@CryZe
Copy link
Contributor

CryZe commented Jan 3, 2018

The memory usage drop is just while compiling right? I feel like that should be specified, otherwise you might falsely assume that the compiled programs use less memory. (I may be wrong about that, which even more proves that this is very unclear atm)

@steveklabnik
Copy link
Member Author

Uh yeah, I think you're right. @alexcrichton ?

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a commit to add a missing url for hoedown, i approve now!

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🎉


## What's in 1.23.0 stable

New year, new Rust! For our first improvement today, we now [avoid some uneccesary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo: unnecessary

like to still support Rust versions before Rust 1.23, you can do this:

```rust
#[warn(unused_imports)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be #[allow(unused_imports)]?

use std::ascii::AsciiExt;
```

To supress the related warning. Once you drop support for older Rusts, you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: suppress

up to you, but you could also do something like this to indicate the words after the code block are a continuation of the previous sentence:

…to suppress the related warning. Once you drop support for older Rusts, you can remove both lines, and everything will continue to work.

Additionally, a few new APIs were stabilized this release:

* The various [`std::sync::atomic
types`](https://doc.rust-lang.org/beta/std/sync/atomic/index.html#structs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be linking to /beta?

@steveklabnik
Copy link
Member Author

Thanks @frewsxcv !

@steveklabnik
Copy link
Member Author

@CryZe i've fixed up the wording, you were correct!

@steveklabnik steveklabnik merged commit 43eb12a into gh-pages Jan 4, 2018
@steveklabnik steveklabnik deleted the 1.23-announcement branch January 4, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants