-
Notifications
You must be signed in to change notification settings - Fork 302
Rust 1.23 release #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 1.23 release #223
Conversation
r? @rust-lang/core |
The memory usage drop is just while compiling right? I feel like that should be specified, otherwise you might falsely assume that the compiled programs use less memory. (I may be wrong about that, which even more proves that this is very unclear atm) |
Uh yeah, I think you're right. @alexcrichton ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a commit to add a missing url for hoedown, i approve now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! 🎉
_posts/2018-01-04-Rust-1.23.md
Outdated
|
||
## What's in 1.23.0 stable | ||
|
||
New year, new Rust! For our first improvement today, we now [avoid some uneccesary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo: unnecessary
_posts/2018-01-04-Rust-1.23.md
Outdated
like to still support Rust versions before Rust 1.23, you can do this: | ||
|
||
```rust | ||
#[warn(unused_imports)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be #[allow(unused_imports)]
?
_posts/2018-01-04-Rust-1.23.md
Outdated
use std::ascii::AsciiExt; | ||
``` | ||
|
||
To supress the related warning. Once you drop support for older Rusts, you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: suppress
up to you, but you could also do something like this to indicate the words after the code block are a continuation of the previous sentence:
…to suppress the related warning. Once you drop support for older Rusts, you can remove both lines, and everything will continue to work.
_posts/2018-01-04-Rust-1.23.md
Outdated
Additionally, a few new APIs were stabilized this release: | ||
|
||
* The various [`std::sync::atomic | ||
types`](https://doc.rust-lang.org/beta/std/sync/atomic/index.html#structs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be linking to /beta
?
Thanks @frewsxcv ! |
@CryZe i've fixed up the wording, you were correct! |
No description provided.