Skip to content

Switch to upstream Zola #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Switch to upstream Zola #1632

merged 3 commits into from
Jun 4, 2025

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Jun 1, 2025

All of the patches we needed for the migration have been merged upstream (with some modifications, hence the sort_by = "permalink" diff).

We don't know how long it will take for Zola to cut a new release, so let's provide our own binaries to blog authors in the meantime.

Rendered

@senekor senekor force-pushed the senekor-qonutkpxlntw branch from d5f9349 to 940afa8 Compare June 1, 2025 13:05
@senekor
Copy link
Contributor Author

senekor commented Jun 1, 2025

I tried and failed to run the snapshot tests in CI. The reason is that only one version of zola is installed for both the "before" and "after" builds of the site. However, the new version of zola we're using relies on the sort_by = "permalink" lines, otherwise the order of posts is messed up. At the same time, the old version of Zola cannot be used either, because it errors out on the unknown value "permalink" for the sort_by key.

However, I did run the tests locally:

  1. Install old version of zola
  2. Build "before" snapshots on master branch
  3. Install new version of zola
  4. Test snapshots on the PR branch

The tests passed, so I'm confident there is no impact on the site.

@senekor senekor requested a review from Manishearth June 1, 2025 13:11
@senekor
Copy link
Contributor Author

senekor commented Jun 1, 2025

Maybe worth mentioning: If this is merged, people who currently have my fork of zola installed will run into build errors (due to the unknown "permalink" value). The solution is to install the new version. I don't expect this to happen when Zola has an official release and we can switch to using those binaries, they should be compatible.

@senekor senekor force-pushed the senekor-qonutkpxlntw branch from 940afa8 to 58cb2ad Compare June 2, 2025 09:34
@senekor senekor force-pushed the senekor-qonutkpxlntw branch from 58cb2ad to 1cf1145 Compare June 2, 2025 20:09
@senekor senekor changed the title Provide prebuilt binaries for Zola Switch to upstream Zola Jun 2, 2025
@senekor senekor requested a review from Manishearth June 2, 2025 20:09
@senekor senekor linked an issue Jun 2, 2025 that may be closed by this pull request
@senekor senekor force-pushed the senekor-qonutkpxlntw branch from 1cf1145 to 39d9396 Compare June 2, 2025 22:11
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@senekor senekor force-pushed the senekor-qonutkpxlntw branch 2 times, most recently from bb9fc68 to 966d1b3 Compare June 2, 2025 22:15
All of the patches we needed for the migration have been merged upstream
(with some modifications, hence the `sort_by = "permalink"` diff).

We use a submodule of Zola so we can better control the version of Zola
that blog authors are running locally.
@senekor senekor force-pushed the senekor-qonutkpxlntw branch from 966d1b3 to e3bc8a9 Compare June 2, 2025 22:16
@senekor senekor merged commit 55de40e into master Jun 4, 2025
5 checks passed
@senekor senekor deleted the senekor-qonutkpxlntw branch June 4, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usa a stable Zola release
3 participants