Skip to content

Final crate update #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 27, 2020

No description provided.

@qryxip qryxip force-pushed the ja-all-enabled-final-crate-update branch from 4066413 to f733747 Compare January 29, 2020 09:49
@qryxip
Copy link
Member Author

qryxip commented Jan 29, 2020

先に #39 を..

@qryxip qryxip force-pushed the ja-all-enabled-final-crate-update branch from f733747 to 088bbd9 Compare January 29, 2020 17:38
@qryxip
Copy link
Member Author

qryxip commented Jan 29, 2020

dep-testsが微妙な気しかしないので削除、代わりにtest-examplesをCI上の全toolchain上で動かします。

@qryxip qryxip force-pushed the ja-all-enabled-final-crate-update branch from 088bbd9 to 1b25307 Compare January 29, 2020 17:50
@qryxip qryxip requested a review from statiolake January 29, 2020 18:08
@qryxip qryxip force-pushed the ja-all-enabled-final-crate-update branch from 1b25307 to 79f9b1b Compare January 30, 2020 05:03
@qryxip
Copy link
Member Author

qryxip commented Jan 30, 2020

examplesをproconio v0.3.5に追従させることを忘れてたのでアップデート

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。変更点は以下のとおりだと理解しました。

  • AtCoderにrejectされたクレートをCargo.tomlから削除。また、それらに関係するテストケースも削除
  • AtCoderにacceptされたクレートを最新版にアップデート
  • CIのRustバージョンを1.39.0から1.40.0にアップデート
  • dep-testsを削除し、代わりにtest-examplesをCI上の全toolchain上で動かす

AtCoderにacceptされたクレートについては、私はリストが見られないので確認できていません。
もし、修正が必要になったら、pull requestを新たに提出してください。

@tatsuya6502
Copy link
Member

tatsuya6502 commented Jan 30, 2020

レビューOKですので、マージします。

@tatsuya6502 tatsuya6502 merged commit 688d594 into rust-lang-ja:ja-all-enabled Jan 30, 2020
@qryxip qryxip deleted the ja-all-enabled-final-crate-update branch January 30, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants