Make the test of jemalloc optional #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jemalloc is not supported on Windows (MSVC). There's no way to run tests of other crates without manually removing jemalloc dependencies and integration tests. This may lead some mistake (e.g. including jemalloc removed `Cargo.toml` to the commit mistakenly) so I want to make easier to ignore the test on Windows. Now, the test will be run only when `jemalloc` feature is enabled. Note that the feature is default feature, since completely ignoring the test by default will forget running the test forever. So `cargo test` will run the test usually. To ignore the test, run `cargo test --no-default-features` to disable `jemalloc` feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jemalloc は Windows (MSVC) ではサポートされていないため、現状 Windows でこれらのテストを実行するには一々 jemalloc 系の依存とテストを削除しなければなりません。これは面倒ですし、編集した Cargo.toml やテストの削除を誤ってコミットに含んでしまう危険性もあります。
本来ならば Unix 環境でだけこのテストを有効化できればよかったのですが、おそらくこのあたりで議論はされているものの現状の解決はないように見えます。とりあえず jemalloc 関連の機能をフィーチャー
jemallocでまとめ、このフィーチャーが有効なときだけテストを実行することにしました。とはいえ実行を忘れてしまっても困るのでこれはデフォルトフィーチャーにしておきます。 Windows でテストする方がいらっしゃればcargo test --no-default-featuresとすれば jemalloc を無視してテストをします。より良い方法があればぜひお教えください。