Implement twosat #43
Merged
Implement twosat #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified by this submit |
manta1130
force-pushed
the
feature/twosat
branch
from
68e5d1d to
c0862e8
Compare
qryxip
reviewed
Sep 12, 2020
qryxip
reviewed
Sep 12, 2020
src/twosat.rs
Outdated
| pub fn add_clause(&mut self, i: usize, f: bool, j: usize, g: bool) { | ||
| assert!(i < self.n && j < self.n); | ||
| self.scc | ||
| .add_edge(2 * i + if f { 0 } else { 1 }, 2 * j + if g { 1 } else { 0 }); |
There was a problem hiding this comment.
In Rust we have <{integer} as From<bool>> but I don't know we should use this...
assert_eq!(0, u32::from(false));
assert_eq!(1, u32::from(true));There was a problem hiding this comment.
I think using explicit type conversion is more simpler than using if expression but I'm not sure if this way is common usage.
koba-e964
reviewed
Sep 13, 2020
TonalidadeHidrica
approved these changes
Sep 13, 2020
|
I've fixed based on reviews. |
This reverts commit 209a624.
koba-e964
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #40