Skip to content

Implement internal_type_traits #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2020
Merged

Implement internal_type_traits #19

merged 4 commits into from
Sep 9, 2020

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Sep 8, 2020 •
edited
Loading

Separated from #14.

I'm not sure other modules use this in what way. We want 0 or MAX in many modules.

@qryxip qryxip force-pushed the internal-type-traits branch from cfe7146 to aeffd20 Compare September 8, 2020 13:36
@qryxip qryxip mentioned this pull request Sep 8, 2020
Merged
@TonalidadeHidrica
Copy link
Collaborator

I guess having max_value and min_value for Integral trait may be useful.

@qryxip qryxip force-pushed the internal-type-traits branch from b47ff90 to 48ece04 Compare September 9, 2020 01:16
@qryxip qryxip marked this pull request as ready for review September 9, 2020 01:17
@TonalidadeHidrica TonalidadeHidrica mentioned this pull request Sep 9, 2020
Merged
@kenkoooo kenkoooo mentioned this pull request Sep 9, 2020
Merged
@qryxip
Copy link
Member Author

qryxip commented Sep 9, 2020

I will merge this PR according to this.

@qryxip qryxip merged commit 46c1ba5 into rust-lang-ja:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@statiolake statiolake statiolake left review comments

@kenkoooo kenkoooo kenkoooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qryxip @TonalidadeHidrica @kenkoooo @statiolake