Skip to content

N25 final #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 8, 2021
Merged

N25 final #779

merged 11 commits into from
Sep 8, 2021

Conversation

AngelOnFira
Copy link
Member

@AngelOnFira AngelOnFira commented Sep 8, 2021

Part of #751

Preview (f628ccb): https://agitated-saha-af60ca.netlify.app/news/025/

Todo:

  • Add sections at the bottom
  • Line length rewrap
  • Full spelling and grammar pass

Aiming to release this in around 12 hours.
Expected release time is 18:00 GMT

@septum
Copy link
Contributor

septum commented Sep 8, 2021

Hi! There's a slight mistake with the developers of TO BE DIRE. This was addressed in the Rusty Jam's Discord and the game's itch.io page. So, the change would be in the index.md in line 73 :

- Third place: [To be Dire][rusty-jam-third-place] by septum

To be changed with:

- Third place: [TO BE DIRE][rusty-jam-third-place] by mdaffin, 
  TimeLark and septum

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, though I've marked a couple of style issues in comments where possible.

Also the rx section violates a few style guidelines.
First, the template assumes that the website, code, and community links should be placed into a braced list like "rx (website, code, Discord) by @cloudhead is a modern and minimalist pixel editor written in Rust."
Second, the changelist is formatted as code block and it'll cause horizontal scroll on mobile.

@AngelOnFira AngelOnFira requested a review from ozkriff September 8, 2021 15:34
@AngelOnFira
Copy link
Member Author

@ozkriff All of your notes should be resolved 💯

* N25: Dimforge

* N25: Humankind

* N25: Humankind: Smaller img
@AngelOnFira
Copy link
Member Author

I'll aim to merge in about 2 hours, which will hopefully give any final reviewers time to check out stuff.

@AngelOnFira AngelOnFira merged commit c1cffd5 into source Sep 8, 2021
@AngelOnFira AngelOnFira deleted the n25-final branch September 8, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants