Skip to content

N22: Rustcraft #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 4, 2021
Merged

N22: Rustcraft #643

merged 6 commits into from
Jun 4, 2021

Conversation

dskart
Copy link
Contributor

@dskart dskart commented Jun 1, 2021

Part of #640

@dskart dskart changed the title N22: Add Rustcraft N22: Rustcraft Jun 1, 2021
17cupsofcoffee
17cupsofcoffee requested changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a bit of repetition in the text.

Also, the image is quite large, could you replace it with this optimized version?

rustcraft(1)

ozkriff
ozkriff reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is quite minimal. Maybe add a few overview/context sentences from the readme or the reddit post?

@dskart dskart requested review from ozkriff and 17cupsofcoffee June 2, 2021 17:18
17cupsofcoffee
17cupsofcoffee approved these changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Jun 2, 2021 •
edited
Loading

Whoops, didn't notice that trailing space - still getting used to having to manually run CI for new contributors... Have started another run, thanks for the quick fix :)

@AngelOnFira AngelOnFira merged commit 46c04e7 into rust-gamedev:source Jun 4, 2021
@AngelOnFira
Copy link
Member

💯

@ozkriff ozkriff mentioned this pull request Jun 8, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@ozkriff ozkriff Awaiting requested review from ozkriff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dskart @17cupsofcoffee @AngelOnFira @ozkriff