Fix sort order on the homepage #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @ozkriff, the homepage wasn't actually being sorted in date order. Upon some digging, I found that they were actually being sorted in reverse alphabetical order - it just so happened that we've not broken that pattern of post names since the site launched 😆
In my defense, the Zola theme I used as reference for implementing this site also makes this mistake...
The fix is to properly sort the
postssection by date, and then remove the reversing logic from the template. This also has the nice side effect of giving us access to the next/previous post as template variables, so I might integrate that into the template at a later date 😄