Skip to content

N19: Release #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 8, 2021
Merged

N19: Release #525

merged 9 commits into from
Mar 8, 2021

Conversation

AngelOnFira
Copy link
Member

@AngelOnFira AngelOnFira commented Mar 7, 2021 •
edited
Loading

Everyone is invited to review!

Preview is here: https://agitated-saha-af60ca.netlify.app/posts/newsletter-019/
(218fbfc)

This will be merged tomorrow, the 8th of March 🎉

Part of #496

@kvark
Copy link
Collaborator

kvark commented Mar 7, 2021

Is there a preview render to review the whole thing?

@AngelOnFira
Copy link
Member Author

@kvark Working on it 😛 just figuring out how we normally do this part of the process

@Keavon
Copy link
Contributor

Keavon commented Mar 7, 2021 •
edited
Loading

If it's possible to get a last-minute inclusion: #526

Sorry for this missing the press deadline. I'm back home (California) after several long days of traveling to visit the SpaceX Starship launch in Texas 🚀.

@AngelOnFira AngelOnFira mentioned this pull request Mar 8, 2021
Closed
ozkriff
ozkriff reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall
but needs a Grammarly pass to catch some simple typos here and there

@AngelOnFira
Copy link
Member Author

Finished the spelling/grammar/formatting pass

@AngelOnFira AngelOnFira requested a review from ozkriff March 8, 2021 13:39
ozkriff
ozkriff approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

17cupsofcoffee
17cupsofcoffee approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar nitpicks but looks good to go otherwise:

@AngelOnFira AngelOnFira merged commit 7dab20d into rust-gamedev:source Mar 8, 2021
@AngelOnFira AngelOnFira deleted the n19-release branch March 8, 2021 18:45
@AngelOnFira
Copy link
Member Author

🚀 🎉

@ozkriff
Copy link
Member

ozkriff commented Mar 8, 2021

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@AlexEne AlexEne Awaiting requested review from AlexEne

@erlend-sh erlend-sh Awaiting requested review from erlend-sh

@logicsoup logicsoup Awaiting requested review from logicsoup

@Lokathor Lokathor Awaiting requested review from Lokathor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AngelOnFira @kvark @Keavon @ozkriff @17cupsofcoffee