-
Notifications
You must be signed in to change notification settings - Fork 343
N19: Add Harvest Hero #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for unfixed linter warnings:
content/posts/newsletter-019/index.md:85 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
content/posts/newsletter-019/index.md:90:81 MD013/line-length Line length [Expected: 80; Actual: 100]
content/posts/newsletter-019/index.md:91:81 MD013/line-length Line length [Expected: 80; Actual: 96]
and the GIF's size: 20.5MBs (should be <2.5MB)
Here's the GIF shrinker we usually use, if you need it: https://ezgif.com/optimize |
Are you able to make the requested changes @Bombfuse? |
Apologies, have been very busy this week. Will work on this and try to get it fixed by 10pm PST |
No problem, know the feeling :) |
Amended the commit with an optimized gif and lint updates. Unable to lint locally right now, so I'm using the github PR checks 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the PR! |
Part of #496