Skip to content

N19: Add Harvest Hero #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2021
Merged

N19: Add Harvest Hero #502

merged 3 commits into from
Mar 6, 2021

Conversation

Bombfuse
Copy link
Contributor

@Bombfuse Bombfuse commented Mar 2, 2021

Part of #496

@ozkriff ozkriff changed the title Add Harvest Hero section N19: Add Harvest Hero Mar 3, 2021
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for unfixed linter warnings:

content/posts/newsletter-019/index.md:85 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
content/posts/newsletter-019/index.md:90:81 MD013/line-length Line length [Expected: 80; Actual: 100]
content/posts/newsletter-019/index.md:91:81 MD013/line-length Line length [Expected: 80; Actual: 96]

and the GIF's size: 20.5MBs (should be <2.5MB)

@17cupsofcoffee
Copy link
Collaborator

Here's the GIF shrinker we usually use, if you need it: https://ezgif.com/optimize

@17cupsofcoffee
Copy link
Collaborator

Are you able to make the requested changes @Bombfuse?

@Bombfuse
Copy link
Contributor Author

Bombfuse commented Mar 5, 2021

Apologies, have been very busy this week. Will work on this and try to get it fixed by 10pm PST

@17cupsofcoffee
Copy link
Collaborator

No problem, know the feeling :)

@Bombfuse
Copy link
Contributor Author

Bombfuse commented Mar 6, 2021

Amended the commit with an optimized gif and lint updates. Unable to lint locally right now, so I'm using the github PR checks 😅

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit d0b62dd into rust-gamedev:source Mar 6, 2021
@ozkriff
Copy link
Member

ozkriff commented Mar 6, 2021

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants