Skip to content

Fix RSS Link in Site Footer #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2020
Merged

Fix RSS Link in Site Footer #115

merged 1 commit into from
May 2, 2020

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented May 1, 2020

Change feed.xml -> rss.xml.

@zicklag
Fix RSS Link in Site Footer
3a7da10 
Change feed.xml -> rss.xml.
17cupsofcoffee
17cupsofcoffee approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the feed.xml link still works, as it's set up as a redirect:

image

BUT there's no reason for us to still be directly linking to that instead of the canonical URL, so this seems like a good change.

@ozkriff ozkriff merged commit 5b7c6d8 into rust-gamedev:source May 2, 2020
@ozkriff
Copy link
Member

ozkriff commented May 2, 2020

Nice, thanks!

@zicklag zicklag deleted the fix-rss-link branch May 2, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zicklag @ozkriff @17cupsofcoffee