Skip to content

Incorrect LD/TARGET_LD env vars #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rich-g opened this issue Sep 26, 2022 · 1 comment
Closed

Incorrect LD/TARGET_LD env vars #128

rich-g opened this issue Sep 26, 2022 · 1 comment

Comments

@rich-g
Copy link

rich-g commented Sep 26, 2022

It seems like there's a typo for LD/TARGET_LD in the do_compile() task:

meta-rust-bin/classes/cargo.bbclass

Lines 119 to 120 in d272f96

export TARGET_LD="${WRAPPER_DIR}/ld-wrapper.sh"
export LD="${WRAPPER_DIR}/ld-native-wrapper.sh"

I think these should instead be:

export TARGET_LD="${WRAPPER_DIR}/linker-wrapper.sh"
export LD="${WRAPPER_DIR}/linker-native-wrapper.sh"
rich-g added a commit to rich-g/meta-rust-bin that referenced this issue Sep 26, 2022
@rich-g
Fix incorrect LD/TARGET_LD env vars
c7cfd61 
The env vars LD and TARGET_LD are exported, but incorrectly refer to a script that doesn't exist (probably a typo). Fix the typo to refer to the proper scripts.

Fixes rust-embedded#128
@rich-g rich-g mentioned this issue Sep 26, 2022
Closed
samliddicott pushed a commit to samliddicott/meta-rust-bin that referenced this issue Dec 1, 2022
@rich-g
Fix incorrect LD/TARGET_LD env vars
8c660f2 
The env vars LD and TARGET_LD are exported, but incorrectly refer to a script that doesn't exist (probably a typo). Fix the typo to refer to the proper scripts.

Fixes rust-embedded#128
This was referenced Dec 1, 2022
Closed
Closed
@posborne
Copy link
Member

Fixed by #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@posborne @rich-g