-
Notifications
You must be signed in to change notification settings - Fork 168
Add unwind information to external assembly #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
asm.s
Outdated
.size __msp_r, . - __msp_r | ||
|
||
.section .text.__msp_w | ||
.global __msp_w | ||
.thumb_func | ||
.cfi_startproc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this subroutine may modify the stack pointer depending on whether MSP or PSP is currently being used so it requires a (rather complex?) register rule so let's not add CFI to it in this PR
asm.s
Outdated
.size __psp_r, . - __psp_r | ||
|
||
.section .text.__psp_w | ||
.global __psp_w | ||
.thumb_func | ||
.cfi_startproc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like __msp_w
this can modify the stack pointer so let's leave it out for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me except for the __*sp_w
subroutines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
👎 Rejected by code reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+ |
Build succeeded: |
294: add CFI and size info r=jonas-schievink a=japaric like it was done in rust-embedded/cortex-m#216 and rust-embedded/cortex-m#212 Co-authored-by: Jorge Aparicio <[email protected]>
216: Fix compiletest tests r=therealprof a=jonas-schievink Closes rust-embedded/cortex-m-rt#215 Co-authored-by: Jonas Schievink <[email protected]>
Add unwind information to the external assembly files, as discussed in #215.
The
.debug_frame
section is now present: