0.6.2 #187
0.6.2 #187
Conversation
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
build.rs
Outdated
| println!("cargo:rustc-cfg=cortex_m"); | ||
| println!("cargo:rustc-cfg=armv7m"); | ||
| } else if target.starts_with("thumbv7em-") { | ||
| } else if target.starts_with("thumbv7m-") || target.starts_with("thumbv7em-") { |
There was a problem hiding this comment.
I'd rather we do not make this change. If the compiler happens to add special support for thumbv7em which is more than just the DSP extension, e.g. saturated instructions and FPU support, then we do not need to update this crate and all dependencies again.
There was a problem hiding this comment.
This is not a functional change, it just silences a Clippy lint which otherwise fails CI on nightly. Unless I misunderstand what you're saying?
There was a problem hiding this comment.
I'm refererring to the comment new comment below. This code changes the flags passed to rustc based on the architecture we're compiling for and you're saying it does not make sense to pass the armv7em flag because it's not supported at the moment.
If this fixes a clippy lint (not mentioned in the comment) and has no other drawbacks (the opposite of which is implied by the comment, namely that we'll have to add it back once supported) I'm okay with the change but would like to see those facts recorded in the comment. To me it currently reads as if we're simply removing this because we don't need to have now but will later and then have to add it back.
Even though this cfg isn't currently used, printing it doesn't hurt, and it avoids a Clippy lint
187: 0.6.2 r=therealprof a=jonas-schievink Closes #185 Co-authored-by: Jonas Schievink <[email protected]>
Build succeeded |
|
... and published. |
187: Allow nightly to fail in Travis r=therealprof a=korken89 With nightly being a bit skiddish, lets allow nightly to fail. Anyone against? @rust-embedded/cortex-m - [x] @adamgreig - [x] @korken89 - [x] @thejpster - [ ] @ithinuel - [x] @therealprof Co-authored-by: Emil Fresk <[email protected]>
Closes #185