-
Notifications
You must be signed in to change notification settings - Fork 149
Upgrade for Arduino-Espressif32 2.0.x #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While 2.0.x is not available in PIO let's use Tasmota repository. I have tested this code with NodeMCU and ESP32-Wroover IE. In This PR I haven't changed the file structure.
WiFi.setHostname(_state.hostname.c_str()); | ||
#elif defined(ESP8266) | ||
WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY); | ||
//WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commented this lines because it breaks the code in latest WiFi library version. Can I remove this lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing this issue with espressif's platform (version 4.3.0) - see other open pr and this branch:
https://github.com/rjwats/esp8266-react/tree/upgrade-e32-4.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Using your latest version I have the problem with wrong IP as pointed here.
The problem is caused by this line as I told before.
My board is ESP32-Wrover IE.
Best regards.
FWIT I support this PR. I tested it on a clean clone + default framework (2.0.2) + esp32, it compiles and works. #ifdef ESP_IDF_VERSION_MAJOR I don't know how other projects/libs are dealing with this but supporting v2.0 is really needed now. |
Yes agreed, has anyone tested Espressif32 @ 4.3.0 with these changes? |
me-no-dev/ESPAsyncWebServer#1151 Quickly tested, it looks like this issue is affecting the project when upgrading the framework version to 4.3.0. |
we've been testing 4.3.0 on my project and ran into some snags around Wifi and AP (emsesp/EMS-ESP32#473) |
Incorperated changes from here into platform/react upgrade branch: https://github.com/rjwats/esp8266-react/pull/301/files |
4.3.0 support added |
hummm... I can't seem to re-create that, what connection setup are you
using?
…On Sat, 21 May 2022, 18:21 Fernando Garcia, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/framework/WiFiSettingsService.cpp
<#291 (comment)>:
> WiFi.setHostname(_state.hostname.c_str());
#elif defined(ESP8266)
- WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY);
+ //WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY);
Hi!
Using your latest version I have the problem with wrong IP as pointed here
<#285 (comment)>
.
[image: Captura de tela de 2022-05-21 14 15 40]
<https://user-images.githubusercontent.com/2778501/169662481-c6735b6e-122b-4681-94e1-2246a6274cf6.png>
The problem is caused by this line as I told before.
My board is ESP32-Wrover IE.
Best regards.
—
Reply to this email directly, view it on GitHub
<#291 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKE4VHSXUND4Z5O6ENTV6LVLELR7ANCNFSM5STBPKMQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
I'm using default settings for network connection. I have added just this env to .ini file.
|
While 2.0.x is not available in PIO let's use Tasmota repository.
I have tested this code with NodeMCU and ESP32-Wroover IE.
In This PR I haven't changed the file structure.