Skip to content

Upgrade for Arduino-Espressif32 2.0.x #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FernandoGarcia
Copy link

While 2.0.x is not available in PIO let's use Tasmota repository.

I have tested this code with NodeMCU and ESP32-Wroover IE.

In This PR I haven't changed the file structure.

While 2.0.x is not available in PIO let's use Tasmota repository.

I have tested this code with NodeMCU and ESP32-Wroover IE.

In This PR I haven't changed the file structure.
WiFi.setHostname(_state.hostname.c_str());
#elif defined(ESP8266)
WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY);
//WiFi.config(INADDR_ANY, INADDR_ANY, INADDR_ANY);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented this lines because it breaks the code in latest WiFi library version. Can I remove this lines?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this issue with espressif's platform (version 4.3.0) - see other open pr and this branch:

https://github.com/rjwats/esp8266-react/tree/upgrade-e32-4.3.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Using your latest version I have the problem with wrong IP as pointed here.

Captura de tela de 2022-05-21 14 15 40

The problem is caused by this line as I told before.
My board is ESP32-Wrover IE.
Best regards.

@raomin
Copy link
Contributor

raomin commented May 16, 2022

FWIT I support this PR. I tested it on a clean clone + default framework (2.0.2) + esp32, it compiles and works.
Maybe we could condition the changes not to break v1.0.6 with

#ifdef ESP_IDF_VERSION_MAJOR 

I don't know how other projects/libs are dealing with this but supporting v2.0 is really needed now.

@rjwats
Copy link
Owner

rjwats commented May 21, 2022

Yes agreed, has anyone tested Espressif32 @ 4.3.0 with these changes?

@rjwats
Copy link
Owner

rjwats commented May 21, 2022

me-no-dev/ESPAsyncWebServer#1151

Quickly tested, it looks like this issue is affecting the project when upgrading the framework version to 4.3.0.

@proddy
Copy link

proddy commented May 21, 2022

we've been testing 4.3.0 on my project and ran into some snags around Wifi and AP (emsesp/EMS-ESP32#473)

@rjwats
Copy link
Owner

rjwats commented May 21, 2022

Incorperated changes from here into platform/react upgrade branch:

https://github.com/rjwats/esp8266-react/pull/301/files

@rjwats
Copy link
Owner

rjwats commented May 21, 2022

4.3.0 support added

@rjwats rjwats closed this May 21, 2022
@FernandoGarcia FernandoGarcia deleted the upgrade_2.0.x branch May 21, 2022 16:56
@rjwats
Copy link
Owner

rjwats commented Oct 11, 2022 via email

@FernandoGarcia
Copy link
Author

I'm using default settings for network connection.

I have added just this env to .ini file.

[env:esp32dev]
; Comment out min_spiffs.csv setting if disabling PROGMEM_WWW with ESP32
board_build.partitions = min_spiffs.csv
platform = espressif32
board = esp32dev
board_build.filesystem = littlefs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants