Skip to content

fix: correctly check for RegExp #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

fix: correctly check for RegExp #1

merged 1 commit into from
Dec 22, 2022

Conversation

cjwang18
Copy link
Contributor

Changes

  • Fix the code not correctly checking if the currently iterated allowedScope is a RegExp by passing it into the call method
  • Add unit tests for the expected functionality
  • Misc: chmod +x on the husky scripts

Preview

Before Fix

image

After Fix

image

@ridvanaltun ridvanaltun merged commit 289bc4a into ridvanaltun:master Dec 22, 2022
@ridvanaltun
Copy link
Owner

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cjwang18
Copy link
Contributor Author

Thank you so much for the quick turnaround @ridvanaltun!

@cjwang18 cjwang18 deleted the fix/regexp branch December 22, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjwang18 @ridvanaltun