Add JSON decode functions from Js.Json #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
reviewed
Feb 15, 2023
Comment on lines
+3
to
+6
| type jsonReviver | ||
| external asJsonReviver: 'a => jsonReviver = "%identity" | ||
| type jsonReplacer | ||
| external asJsonReplacer: 'a => jsonReplacer = "%identity" |
There was a problem hiding this comment.
What's the point of these? They look unsafe, but are not marked as such. And if they can really be anything, why not just allow anything to be passed directly?
Also, as I understand, jsonReviver can really only be a function. So why isn't it a function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and move classify into separate submodule + add .resi.
Merge #15 first.
Note: I made it Json.Decode.float (Js.Json calls it decodeNumber) and am not providing a Json.Decode.int on purpose.