Fix conditional import / export of streaming functionality #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #179
The
stream
method introduced by #169 requires a readable stream interface. #172 introduced a conditional import, whereby the library attempts to load the built-instream
module and attempts to fall back on thereadable-stream
polyfill. However, something about that seems to confuse Next.js (during tree-shaking?), causing it to report an import error in stream when tracing unrelated errors.This PR refactors this in the following ways:
import
instead ofrequire
createStream
instead ofStream
class; the function canthrow
ifReadable
isn't foundnode:stream
instead ofstream
to help distinguish use of core module (this was introduced in Node.js 14)