Simple led example #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu91
reviewed
Aug 23, 2021
examples/LED/LED.ino
Outdated
| #include <Arduino.h> | ||
| #include "Thing.h" | ||
| #include "WebThingAdapter.h" | ||
| #include <Thing.h> |
There was a problem hiding this comment.
logically Thing.h is not a system library, why did you change " to <?
There was a problem hiding this comment.
That's true. I don't know. Copy, paste, I think? ^^
relu91
requested changes
Aug 23, 2021
examples/LED/LED.ino
Outdated
| Serial.print("state: "); | ||
| Serial.println(state); | ||
|
|
||
| if (state) { |
There was a problem hiding this comment.
isn't this code redundant? the pin will be written soon after the action handler execution in the loop function.
There was a problem hiding this comment.
true. I didn't really pay much attention to it.
|
@relu91 Updated it. |
relu91
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple LED on/off example.