Skip to content

Port Subscription closure implementation from 8.x to 7.x #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markerikson opened this issue Sep 3, 2021 · 0 comments
Closed

Port Subscription closure implementation from 8.x to 7.x #1807

markerikson opened this issue Sep 3, 2021 · 0 comments

Comments

@markerikson
Copy link
Contributor

In #1755, I figured out that we could rewrite the internal Subscription class as a closure instead. This shaves off some bytes thanks to closures minifying better.

However, that change went straight into our master branch as part of v8.x development. We should be able to easily backport this to the 7.x branch and release it in the next patch update.

I'd love to see someone file a PR that makes those same changes to 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant