Skip to content

Fix hooks #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Fix hooks #809

merged 4 commits into from
Sep 14, 2022

Conversation

prahal
Copy link

@prahal prahal commented Apr 20, 2022

unversioned python binary are not there anymore at least in Debian. Fix the plugin gitolite python hooks by specifying the versioned python binary it can cope with.
Note that git_multimail master 1.6dev might cope with python3 binary but current latest release of it 1.5.0 does not and that is the one we ship.
Shipping 1.6dev of it would require checking it is python3 ready.
Also note that git_mulitmail upstream does not version its python binary either.

prahal and others added 4 commits April 20, 2022 21:30
Unversioned python binary is no more.

This reverts commit 4223ad5 "Support both python 2 and 3".
As git_mulitmail python script is still python2 only per 2to3 script
set the binary to python2.
@PowerKiKi
Copy link
Collaborator

Thank you for your work and patience

@PowerKiKi PowerKiKi merged commit aa74f68 into redmine-git-hosting:master Sep 14, 2022
@n-rodriguez
Copy link
Contributor

n-rodriguez commented Sep 16, 2022

Also note that git_mulitmail upstream does not version its python binary either.

if you want to solve this issue you can adapt the code :

  1. add a template true to https://github.com/jbox-web/redmine_git_hosting/blob/master/lib/load_gitolite_hooks.rb#L64
  2. define a new template field here : https://github.com/jbox-web/redmine_git_hosting/blob/master/lib/redmine_git_hosting/gitolite_hook.rb#L17
  3. hook into install_hook_file to do the ERB template rendering between the read and the write
  4. you will need to store the desired target python version in settings

cheers!

@PowerKiKi
Copy link
Collaborator

I'd rather have upstream fix their code by raising their requirements to a non-abandoned python version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants