Skip to content

v0.8 git instructions issue #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rchady opened this issue Nov 4, 2014 · 2 comments
Closed

v0.8 git instructions issue #309

rchady opened this issue Nov 4, 2014 · 2 comments
Assignees
Labels

Comments

@rchady
Copy link

rchady commented Nov 4, 2014

Using the latest devel branch, noticed that the instructions did not list the url for adding the origin. Looked in to it and it seems to be because access.url is not being set. In fact, looking over it, I'm thinking access_list is not getting set at all:

  var access = access_list[key];

Is the call that sets access, but I'm not seeing where access_list is getting defined? Either way, the javascript console shows an error of:

TypeError: undefined is not an object (evaluating 'access.url')

when viewing an empty repository.

NOTE: It does display it in the sidebar, but that partial view builds that information for it to be displayed.

@rchady
Copy link
Author

rchady commented Nov 4, 2014

To answer my own issue, the issue is in git_instructions_html.erb:

  var key = $('#git_url_list li').first().attr('id');

should be

  var key = $('.git_url_list li').first().attr('id');

Works great after that.

@n-rodriguez n-rodriguez added the bug label Nov 8, 2014
@n-rodriguez n-rodriguez self-assigned this Nov 8, 2014
@n-rodriguez
Copy link
Contributor

Thanks Robert!

n-rodriguez pushed a commit that referenced this issue Nov 8, 2014
n-rodriguez pushed a commit that referenced this issue Nov 8, 2014
This reverts commit 959caa7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants