$GITOLITE_HOME/.ssh/authorized_keys not updating

[jamesloosli]

It looks like the plugin is successfully committing and pushing my configuration changes to gitolite-admin.git, but authorized_keys does not contain the new keys.

I'm running redmine 2.5.1 with gitolite 2.3 on debian.

Relevant log showing that keys are being added:

2014-05-05 12:16:14 -0700 INFO [GitHosting] User 'admin' has added a SSH key
2014-05-05 12:16:14 -0700 INFO [GitWorker] Using Gitolite configuration file : 'gitolite.conf'
2014-05-05 12:16:14 -0700 INFO [GitWorker] add_ssh_key : SSH key 'redmine_jloosli@redmine_1399309903_846270' already exists in Gitolite, update it ...
2014-05-05 12:16:14 -0700 INFO [GitWorker] add_ssh_key : SSH key 'redmine_jloosli@redmine_1399317373_556615' does not exist in Gitolite, create it ...
2014-05-05 12:16:14 -0700 INFO [GitWorker] add_ssh_key : commiting to Gitolite...
2014-05-05 12:16:15 -0700 INFO [GitWorker] add_ssh_key : pushing to Gitolite...
2014-05-05 12:16:19 -0700 INFO [GitWorker] add_ssh_key : done !

However, ~/.ssh/authorized_keys for my git user only contains the admin key.

git@cookbook:~$ cat ~/.ssh/authorized_keys 
# gitolite start
command="/usr/share/gitolite/gl-auth-command admin",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAB [...] BNsSQWB51RJc5 [email protected]_redmine_server.com
# gitolite end

[pashamesh]

I also confirm this behavior.

I'm running Redmine 2.5.1 with gitolite 3.5 on Debian.

[pashamesh]

I've also noticed that all new added pub keys are trimmed in gitolite repository files in «keys» folder

[n-rodriguez]

This is weird, the trim should only happen with the devel branch.

The bug had been introduced in this commit afe951e (the field key in the gitolite_public_key table was converted from text to string) but is now fixed in the last commit ae48a33.

[pashamesh]

I've fixed this using mysql query:

ALTER TABLE `gitolite_public_key` MODIFY `key` TEXT;

[jamesloosli]

Did this fix the keys in ~/.ssh/authorized_keys?

On Tuesday, May 6, 2014, Pasha MESH [email protected] wrote:

I've fixed this using mysql query «ALTER TABLE gitolite_public_key MODIFY
key TEXT».

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/187#issuecomment-42286071
.

[pashamesh]

Nope. Need to recreate keys

[jamesloosli]

After you re-created the keys, were new keys added to authorized_keys?

[jamesloosli]

It looks like my database entries were already correct.

mysql> describe gitolite_public_keys;

+--------------------+--------------+------+-----+---------+----------------+

| Field              | Type         | Null | Key | Default | Extra
|

+--------------------+--------------+------+-----+---------+----------------+

| id                 | int(11)      | NO   | PRI | NULL    | auto_increment
|

| user_id            | int(11)      | NO   | MUL | NULL    |
|

| key_type           | int(11)      | NO   |     | 0       |
|

| title              | varchar(255) | NO   |     | NULL    |
|

| identifier         | varchar(255) | NO   | MUL | NULL    |
|

| key                | text         | NO   |     | NULL    |
|

| active             | tinyint(1)   | YES  |     | 1       |
|

| delete_when_unused | tinyint(1)   | YES  |     | 1       |
|

| created_at         | datetime     | NO   |     | NULL    |
|

| updated_at         | datetime     | NO   |     | NULL    |
|

+--------------------+--------------+------+-----+---------+----------------+

10 rows in set (0.00 sec)

On Tue, May 6, 2014 at 9:10 AM, Pasha MESH [email protected] wrote:

Nope. Need to recreate keys

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/187#issuecomment-42323230
.

[pashamesh]

Maybe, migration fix problem, but key was already trimmed

[pashamesh]

Try to add new key

[jamesloosli]

Neither of my keys were trimmed. I'll try to delete and re-add.

On Tue, May 6, 2014 at 11:25 AM, Pasha MESH [email protected]:

Try to add new key

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/187#issuecomment-42339973
.

[n-rodriguez]

This is fixed in commit ae48a33.

Btw, be sure to use a stable branch (or a tarball release) and not the devel (devil?) branch ;)

[philippe-bollard]

I'm sorry but the commit ae48a33 didn't fix the bug. I currently running redmine_git_hosting 0.7.2 (migrated from 0.6.1) on Redmine 2.3.0.stable.11727 with Gitolite 2.3-1 and Git 1.9.1.

I checked the database, the keys, ... everything is OK but the file ".ssh/authorized_keys" is never updated when I add a key.

EDIT: I upgraded to latest Redmine 2.5.1. The bug is still here :(