Skip to content

Graph - add counters for removed labels and properties #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 26, 2022
+71 −0
Merged

Graph - add counters for removed labels and properties #2292

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cb4f767
grpah - add counters for removed labels and properties
DvirDukhan Jul 19, 2022
6b3931b
Merge branch 'master' into graph_new_statistics
DvirDukhan Jul 24, 2022
ebfa03a
added mock graph result set statistics
DvirDukhan Jul 25, 2022
883bdc8
Merge branch 'graph_new_statistics' of https://github.com/DvirDukhan/…
DvirDukhan Jul 25, 2022
74635be
docstrings for graph result set statistics
DvirDukhan Jul 25, 2022
15ca812
format
DvirDukhan Jul 25, 2022
f58843d
isort
DvirDukhan Jul 25, 2022
5ded519
Merge branch 'master' into graph_new_statistics
DvirDukhan Jul 25, 2022
6def0e4
Merge branch 'master' into graph_new_statistics
DvirDukhan Jul 25, 2022
4f1358a
Merge branch 'master' into graph_new_statistics
DvirDukhan Jul 26, 2022
6403620
moved docstrings into functions
DvirDukhan Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions redis/commands/graph/query_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@
from .path import Path

LABELS_ADDED = "Labels added"
LABELS_REMOVED = "Labels removed"
NODES_CREATED = "Nodes created"
NODES_DELETED = "Nodes deleted"
RELATIONSHIPS_DELETED = "Relationships deleted"
PROPERTIES_SET = "Properties set"
PROPERTIES_REMOVED = "Properties removed"
RELATIONSHIPS_CREATED = "Relationships created"
INDICES_CREATED = "Indices created"
INDICES_DELETED = "Indices deleted"
Expand All @@ -21,8 +23,10 @@

STATS = [
LABELS_ADDED,
LABELS_REMOVED,
NODES_CREATED,
PROPERTIES_SET,
PROPERTIES_REMOVED,
RELATIONSHIPS_CREATED,
NODES_DELETED,
RELATIONSHIPS_DELETED,
Expand Down Expand Up @@ -325,6 +329,10 @@ def _get_stat(self, stat):
def labels_added(self):
return self._get_stat(LABELS_ADDED)

@property
def labels_removed(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add docstrings to each of these

return self._get_stat(LABELS_REMOVED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though they're "gimmes" we should have unit tests, covering each property - this way we don't break them in the future.


@property
def nodes_created(self):
return self._get_stat(NODES_CREATED)
Expand All @@ -337,6 +345,10 @@ def nodes_deleted(self):
def properties_set(self):
return self._get_stat(PROPERTIES_SET)

@property
def properties_removed(self):
return self._get_stat(PROPERTIES_REMOVED)

@property
def relationships_created(self):
return self._get_stat(RELATIONSHIPS_CREATED)
Expand Down