Skip to content

Drop python 3.6 support #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Drop python 3.6 support #374

merged 3 commits into from
Sep 7, 2022

Conversation

dvora-h
Copy link
Contributor

@dvora-h dvora-h commented Sep 6, 2022

This PR aligns OM with redis-py. As redis-py starting in 4.4 now removes support for Python 3.6, as promised, this aligns OM.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #374 (91737f2) into main (a00a68b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   77.62%   77.64%   +0.01%     
==========================================
  Files          14       14              
  Lines        1153     1154       +1     
==========================================
+ Hits          895      896       +1     
  Misses        258      258              
Flag Coverage Δ
unit 77.64% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aredis_om/model/model.py 86.50% <0.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chayim
Copy link
Contributor

chayim commented Sep 7, 2022

@dvora-h Please look at the pyproject.toml, I think we should remove the trove.

@dvora-h
Copy link
Contributor Author

dvora-h commented Sep 7, 2022

@chayim I deleted

@dvora-h dvora-h merged commit 788d3df into main Sep 7, 2022
@dvora-h dvora-h deleted the drop-3.6 branch September 7, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants