Skip to content

Fixes issue decode_responses is set to True regardless if REDIS_OM_UR… #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Fixes issue decode_responses is set to True regardless if REDIS_OM_UR… #373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
433687a
Fixes issue decode_responses is set to True regardless if REDIS_OM_UR…
melder Sep 6, 2022
db1f166
Merge branch 'main' into redis_env_var_decode_responses_fix
dvora-h Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions aredis_om/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@


def get_redis_connection(**kwargs) -> redis.Redis:
# Decode from UTF-8 by default
if "decode_responses" not in kwargs:
kwargs["decode_responses"] = True

# If someone passed in a 'url' parameter, or specified a REDIS_OM_URL
# environment variable, we'll create the Redis client from the URL.
url = kwargs.pop("url", URL)
if url:
return redis.Redis.from_url(url, **kwargs)

# Decode from UTF-8 by default
if "decode_responses" not in kwargs:
kwargs["decode_responses"] = True
return redis.Redis(**kwargs)