Skip to content

Fix crash when trying to delete non-existent record #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

dvora-h
Copy link
Contributor

@dvora-h dvora-h commented Sep 6, 2022

Fixes #355

@dvora-h dvora-h added the bug Something isn't working label Sep 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #372 (6205d3a) into main (c6fb00b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   77.64%   77.80%   +0.16%     
==========================================
  Files          14       14              
  Lines        1154     1158       +4     
==========================================
+ Hits          896      901       +5     
+ Misses        258      257       -1     
Flag Coverage Δ
unit 77.80% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aredis_om/model/model.py 86.68% <100.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chayim chayim merged commit e9529e3 into main Sep 15, 2022
@chayim chayim deleted the delete-non-exist branch September 15, 2022 10:29
@dvora-h dvora-h restored the delete-non-exist branch September 15, 2022 15:33
@dvora-h dvora-h deleted the delete-non-exist branch September 15, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete will throw an exception if invoked on a non existing record.
3 participants