-
Notifications
You must be signed in to change notification settings - Fork 45
RHIDP-6570: Document the permission support to RBAC plugin #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1079/ @ 04/29/25 10:51:15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but we probably should include more information about what conditional rule to use and who to set it to. As well as what specific steps the team lead will need to take to ensure that they can see the roles and permissions that they create. Here is some docs that I have written for the RBAC backend plugin upstream.
a01dc18
to
ebde911
Compare
ebde911
to
0a52ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairly minor, and I need to fix it in the upstream docs as well, but I am working on removing the resource type from the policy.entity.create
permission. This means that at some point in the future, admins will no longer be able to create permissions using policy-entity, create
and will instead need to use policy.entity.create, create
.
I was hoping that we could use your PR to make that change. It looks like the create policy permission is only referenced in one other location. Do you mind updating it as well to remove the policy-entity
from policy.entity.create
?
103f5fa
to
242bfa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request
77e6bcf
to
ce339ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me
/cherry-pick release-1.6 |
@themr0c: new pull request created: #1115 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.6
Issue:
RHIDP-6570
Preview: