Skip to content

RHIDP-6568: Create RHDH Metadata card customization content #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2025
Merged

Conversation

linfraze
Copy link
Member

@linfraze linfraze commented Apr 11, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Apr 11, 2025

Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thank you !

@linfraze linfraze added Peer review needed 📖 Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Apr 18, 2025
Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linfraze I left a couple of comments/suggestions.

@hmanwani-rh
Copy link
Member

@linfraze Seems like some comments are unresolved in this PR. Please resolve those comments and we can proceed with merging.

@themr0c themr0c merged commit 9e16c78 into main May 12, 2025
3 checks passed
@themr0c themr0c deleted the RHIDP-6568 branch May 12, 2025 11:41
@themr0c
Copy link
Member

themr0c commented May 12, 2025

/cherry-pick release-1.6

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #1151

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants