-
Notifications
You must be signed in to change notification settings - Fork 46
RHDHPAI-735: Configuration info and other issues to fix #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1060/ @ 04/25/25 07:12:52 |
/lgtm |
modules/observe/adoption-insights/proc-install-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-configure-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
Should this PR also mention the segment plugin issue from release notes? I think so |
@evanshortiss, Regarding the part on including the disabling the segment plugin, it might be more appropriate to include it in the release notes, especially since it could be addressed in an upcoming release. |
@pabel-rh what if someone is excited to try the new feature, but doesn't read the release notes and encounters an error? IMO documentation should be complete for the reader in the now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments / suggestions. Looks good overall!
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
modules/observe/adoption-insights/proc-viewing-adoption-insights-card.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
modules/observe/adoption-insights/con-about-adoption-insights.adoc
Outdated
Show resolved
Hide resolved
…adoc Co-authored-by: Judith Magak <[email protected]>
New changes are detected. LGTM label has been removed. |
/cherry-pick release-1.5 |
@themr0c: new pull request created: #1104 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@themr0c: #1060 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pabel-rh Can you do a manual cherry-pick to release-1.6? |
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.5.x, main, 1.6
Issue:
RHDHPAI-735
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1060/adoption-insights/