Skip to content

do not create 404 page for embedded (e.g. ePub) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged

do not create 404 page for embedded (e.g. ePub) #231

merged 2 commits into from
May 8, 2024

Conversation

methane
Copy link
Contributor

@methane methane commented May 7, 2024

fix #230

@methane methane requested a review from a team as a code owner May 7, 2024 14:48
@methane methane requested a review from humitos May 7, 2024 14:48
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great to me 💯

@humitos humitos merged commit 19cc822 into readthedocs:main May 8, 2024
7 checks passed
@humitos
Copy link
Member

humitos commented May 21, 2024

I just released 1.0.1 with this fix. Please, let me know if it works as you expected 👍🏼

@methane methane deleted the no-404-epub branch May 21, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not produce 404.xhtml in epub and htmlhelp
2 participants