Skip to content

Resolve deprecation warning #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drts01 opened this issue May 21, 2024 · 2 comments · Fixed by #236
Closed

Resolve deprecation warning #234

drts01 opened this issue May 21, 2024 · 2 comments · Fixed by #236

Comments

@drts01
Copy link
Contributor

drts01 commented May 21, 2024 •
edited
Loading 

.../site-packages/notfound/extension.py:269: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  default, rebuild, types = app.config.values.get('notfound_urls_prefix')

Version 1.0.1
@humitos
Copy link
Member

humitos commented May 21, 2024

Hi @xsc27! Thanks for reporting this issue. Would you like to open a PR to solve it?

@humitos humitos mentioned this issue May 21, 2024
Closed
@drts01
Copy link
Contributor Author

drts01 commented May 21, 2024

Yes. Gladly.

drts01 added a commit to drts01/sphinx-notfound-page that referenced this issue May 23, 2024
@drts01
fix _Opt deprecation warning
f8fb51d 
closes readthedocs#234
@drts01 drts01 mentioned this issue May 23, 2024
Merged
drts01 added a commit to drts01/sphinx-notfound-page that referenced this issue May 23, 2024
@drts01
fix _Opt deprecation warning
a89cda3 
closes readthedocs#234
drts01 added a commit to drts01/sphinx-notfound-page that referenced this issue May 28, 2024
@drts01
fix _Opt deprecation warning
55f39bb 
closes readthedocs#234
humitos pushed a commit that referenced this issue May 28, 2024
@drts01
fix _Opt deprecation warning (#236)
64ed88f 
* fix _Opt deprecation warning

closes #234

* build(deps): docs

* ci(docs): build on Python 3.12
drts01 added a commit to drts01/sphinx-notfound-page that referenced this issue May 28, 2024
@drts01
fix: check prefix starts and ends with /
4061109 
Bug was introduced in readthedocs#234 64ed88f
@drts01 drts01 mentioned this issue May 28, 2024
Merged
humitos pushed a commit that referenced this issue May 29, 2024
@drts01
fix: check prefix starts and ends with / (#238)
9b0cc7d 
Bug was introduced in #234 64ed88f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix _Opt deprecation warning drts01/sphinx-notfound-page
2 participants
@humitos @drts01