Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Use proxied API endpoint #80

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Use proxied API endpoint #80

merged 1 commit into from
Jul 7, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 18, 2020

This is useful to avoid CORS or to use Read the Docs for Business.

This is useful to avoid CORS or to use Read the Docs for Business.
@humitos humitos requested review from ericholscher and stsewd June 18, 2020 11:12
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we setting this env var? I think we can just default to it if it's runnin on rtd

@humitos
Copy link
Member Author

humitos commented Jun 18, 2020

I didn't want to modify what we had, but add an extra variable. I want to have the flexibility of choosing the proxied API or not so we can test different URLs. The new env var is required on commercial only.

@humitos humitos merged commit d36a2a1 into master Jul 7, 2020
@humitos humitos deleted the proxied-endpoint branch July 7, 2020 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants