jQuery: inject the CDN version if Sphinx>=6.x #204
Conversation
Sphinx>=6.x will remove jQuery framework. As this extension depends on jQuery, we will include it by ourselves
|
|
||
| if sphinx.version_info >= (6, 0, 0): | ||
| # https://jquery.com/download/#using-jquery-with-a-cdn | ||
| jquery_cdn_url = "https://code.jquery.com/jquery-3.6.0.min.js" |
There was a problem hiding this comment.
I noted similar on our theme, it's better to include dependencies via package dependencies for a few reasons:
There was a problem hiding this comment.
Also, this dependency can be brought in without webpack, though a longer term goal would be to use webpack, or more likely to remove jQuery entirely.
To copy the jQuery release into the package, install jQuery via package.json and copy the JS minified file from node_modules/ into the package.
Of course the issues you noted with jQuery versions and conflicting versions between extensions is going to be a problem.
There was a problem hiding this comment.
To copy the jQuery release into the package, install jQuery via
package.jsonand copy the JS minified file fromnode_modules/into the package.
is this better than just grabbing the official minified version from https://jquery.com/download/?
There was a problem hiding this comment.
Yup. It's much easier to keep up to date and we're using npm to manage these dependencies on our other JS projects.
|
Any update here? Is this blocked on discussions upstream at Sphinx about some generalized solution to the jQuery issue? |
|
We have been talking with @benjaoming about creating a minimal |
|
I'm closing this PR for now because we have changed directions here. In any case, we can come back to it if it's required. |
Sphinx>=6.x will remove jQuery framework. As this extension depends on jQuery, we will include it by ourselves.
Closes #160