This repository was archived by the owner on Apr 9, 2025. It is now read-only.
Image inside tooltips don't render #200
Assignees
Comments
7 tasks
|
I just found this issue in our own documentation as well: https://docs.readthedocs.io/en/stable/commercial/single-sign-on.html#single-sign-on |
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this issue
Jun 15, 2022
When returning the content to be injected in a tooltip, besides cleaning the `a.href` we are also cleaning the `img.src` to make them absolute and render the images properly. See readthedocs/sphinx-hoverxref#200
|
I opened readthedocs/readthedocs.org#9337 in the backend which fixes this issue. |
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this issue
Jun 16, 2022
* EmbedAPI: small refactor - rename `clean_links` as `clean_references` - rename `URLData.href` as `URLData.ref` This is done because this function will clean `a.href` and also `img.src` now. * EmbedAPI: clean images (src) properly from inside a tooltip When returning the content to be injected in a tooltip, besides cleaning the `a.href` we are also cleaning the `img.src` to make them absolute and render the images properly. See readthedocs/sphinx-hoverxref#200 * EmbedAPI: use absolute URL on HTML data for tests These `src=` fields are not cleaned by `clean_references`.
|
Looks like that PR got merged. Closing this. 👍 |
Repository owner
moved this from Needs review
to Done
in 📍Roadmap
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The following text was copied and pasted from orchest/orchest#1041 (comment)
Another issue that I noticed is that some images from the tooltips are not being rendered for some reason. It seems it's using a relative path
../_images/services.pngwhen it should be using the absolute path/_images/services.pngThe reST code for this is located at https://github.com/humitos/orchest/blob/625a0f6929f5b7862a0dca4010d55615b8c7e740/docs/source/fundamentals/services.rst#L24
The text was updated successfully, but these errors were encountered: