Settings: simplify all the settings removing a whole old layer (dev)
#9978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using `settings/dev.py` since we started using Docker (`settings/docker_compose.py`). However, we never updated this code. This commit removes the extra `Dev` class layer by moving the required (and still used settings) into `settings/test.py` and `settings/docker_compose.py` since they were inheriting from `settings/dev.py`.
stsewd
approved these changes
Feb 2, 2023
|
I think I missed one setting because there are 2 test cases failing. I'll check it and push a fix. |
|
Documentation is failing because we have a super complex setup 🤯 . I simplified it and removed a lot of unnecessary things in #9981. I'd like to move forward with this because it simplifies the build a lot. |
* Docs: remove outdated and complex code This commit reduces the complexity of the documentation environment by removing the requirement of having Django installed and loaded to build the docs. * Remove the `djangodocs` and `doc_extensions`: they load the whole Django application unnecesarily. We need to have a bunch of requirements installed just because of this. * Remove defaults from "Interesting settings" because all the default were wrong. The Django extension was loading an invalid set of settings. This page could be completely removed as well probably. * Remove `featureflag` role because of the same reason (loads a whole Django project). We were using it only to show a small description of the feature flags. I wrote that text directly in the page. Feature flags are deprecated and this page will probably deleted soon as well. * Remove `buildpyversions` role also. Same reason. Manually wrote the versions supported on each Docker image. This is used for the legacy images, tho. They won't change since we don't maintain them anymore. * Docs: reduce requirements drastically Since we don't depend on Django anymore we can remove the `-r pip.txt` dependency from the documentation. This makes the documentation just to rely on Sphinx and some other extensions only simplifying the environment a lot and running fast. * Docs: don't install `pip.txt` * Docs: remove missing `djangosetting` role
…mitos/settings-simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using
settings/dev.pysince we started using Docker (settings/docker_compose.py).However, we never updated this code.
This commit removes the extra
Devclass layer by moving the required (and still used settings) intosettings/test.pyandsettings/docker_compose.pysince they were inheriting fromsettings/dev.py.Related: https://github.com/readthedocs/readthedocs-ops/issues/937