Proxito: use unresolved domain on middleware #9974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Feb 2, 2023
|
ping @humitos |
ericholscher
approved these changes
Feb 9, 2023
| "Proxito Public Domain -> Canonical Domain Redirect.", | ||
| project_slug=project.slug, | ||
| ) | ||
| request.canonicalize = constants.REDIRECT_CANONICAL_CNAME |
There was a problem hiding this comment.
These constants should probably be an enum as well, next refactor?
There was a problem hiding this comment.
Could be, but I think we could move this logic to the docs serving view, and we won't be needing those constants anymore
|
This is on my list. I'll try to review it on Monday, hopefully |
humitos
approved these changes
Feb 13, 2023
|
I'll merge this after tomorrow's deploy (we have a pending PR that will conflict with the changes here) |
stsewd
added a commit
that referenced
this pull request
Feb 14, 2023
Make use of the unresolved domain from the request instead of each of the attributes we are setting in the request from the middleware, we aren't using any of those on .com, so we are safe removing them here. This is on top of #9974.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map_host_to_projectinto_set_request_attributesandunresolve_domain_from_requestUnresolvedDomaindata class to return from the unresolver.