Skip to content

Refactor projects fixtures #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed

Conversation

tanvimoharir
Copy link
Contributor

Refers #9332
(previously #9411 )

@tanvimoharir tanvimoharir requested a review from a team as a code owner January 23, 2023 09:21
@tanvimoharir tanvimoharir requested a review from stsewd January 23, 2023 09:21
@benjaoming
Copy link
Contributor

benjaoming commented Jan 23, 2023

@tanvimoharir thanks for having patience and helping to throubleshoot a CI issue here 👍

Observing that "checks" now says ✔️ ...

I'm quite sure the previous issue with "checks" failing at pre-commit run --from-ref main --to-ref HEAD was because the forked repo had an out-dated main branch. The comparison is intended to be run against the upstream main branch of readthedocs/readthedocs.org but that's probably not the remote that Circle CI's git checkout points to.

My take: I don't think we can expect a forked repo to always maintain the latest main branch, we need the CI to not rely on that. There are probably a few ways to fix this.

@tanvimoharir
Copy link
Contributor Author

@tanvimoharir thanks for having patience and helping to throubleshoot a CI issue here 👍

Observing that "checks" now says ✔️ ...

I'm quite sure the previous issue with "checks" failing at pre-commit run --from-ref main --to-ref HEAD was because the forked repo had an out-dated main branch. The comparison is intended to be run against the upstream main branch of readthedocs/readthedocs.org but that's probably not the remote that Circle CI's git checkout points to.

My take: I don't think we can expect a forked repo to always maintain the latest main branch, we need the CI to not rely on that. There are probably a few ways to fix this.

thanks @benjaoming for helping me! appreciate it.

@benjaoming benjaoming self-requested a review January 26, 2023 11:15
@humitos
Copy link
Member

humitos commented Aug 9, 2023

Thanks for your time and work here! Unfortunately, we haven't had the time to prioritize this work and review it. I will close this PR for now, but we can come back in the future to recover this work.

@humitos humitos closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants