Skip to content

Docs: update build customization Poetry example #9879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

sethfischer
Copy link
Contributor

@sethfischer sethfischer commented Jan 10, 2023

Move poetry install from post_create_environment to post_install.

This ensures the Sphinx version installed from poetry.lock is used to build the docs, rather than the default version of Sphinx.

Closes: #9869


📚 Documentation previews 📚

Move `poetry install` from `post_create_environment` to `post_install`.

This ensures the Sphinx version installed from `poetry.lock` is used to build
the docs, rather than the default version of Sphinx.

Closes: readthedocs#9869
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 💯 for noticing the "Docs:" preview on the documentation PRs ❤️

@benjaoming
Copy link
Contributor

Note: The build failure in checks is related to blacken-docs. It's because we are not using correct Python syntax in a code-block:: Python -- it's a change that overlapped with the introduction of the blacken-docs pre-commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Sphinx version used during RTD build
2 participants