Skip to content

Docs: Disable ePub as a temporary work-around #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jan 3, 2023

Work-around for #9816

Will merge into diataxis/main after.

@benjaoming benjaoming requested a review from a team as a code owner January 3, 2023 12:50
@benjaoming benjaoming requested a review from stsewd January 3, 2023 12:50
@stsewd
Copy link
Member

stsewd commented Jan 3, 2023

Also, any chance we can fix the warnings instead?

/home/docs/checkouts/readthedocs.org/user_builds/docs/checkouts/diataxis-main/docs/user/guides/git-integrations.rst:18: WARNING: Duplicate explicit target name: "webhook-integration-github".
/home/docs/checkouts/readthedocs.org/user_builds/docs/checkouts/diataxis-main/docs/user/guides/git-integrations.rst:41: WARNING: Duplicate explicit target name: "webhook-integration-bitbucket".
/home/docs/checkouts/readthedocs.org/user_builds/docs/checkouts/diataxis-main/docs/user/guides/git-integrations.rst:51: WARNING: Duplicate explicit target name: "webhook-integration-gitlab".

But I don't see any duplicates in that page, so maybe a bug with sphinx or the tabs extension.

@benjaoming benjaoming changed the title Do not build ePub Disable ePub as a temporary work-around Jan 3, 2023
@benjaoming benjaoming changed the title Disable ePub as a temporary work-around Docs: Disable ePub as a temporary work-around Jan 3, 2023
@benjaoming
Copy link
Contributor Author

Also, any chance we can fix the warnings instead?

#9816 is about finding a way to exclude certain warnings so the ePub build can go ahead despite of the warnings.

We could open an issue about fixing these warnings, but as I understand it from @humitos, we might have already decided in principle to replace sphinx-tabs with sphinx-design.

@benjaoming
Copy link
Contributor Author

Replaced by #9866

@benjaoming benjaoming closed this Jan 5, 2023
@benjaoming benjaoming deleted the formats-pdf branch January 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants