-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Docs: Additions to style guide - placeholders, seealso::, Diátaxis and new word list entry #9840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
161cb88
Propose something about placeholders, seealso:: references and move D…
benjaoming 00d5697
swap . with :
benjaoming 7ccd6eb
sembr a few things
benjaoming 7447543
Apply suggestions from code review @ericholscher
benjaoming 9075733
Merge branch 'main' of github.com:readthedocs/readthedocs.org into st…
benjaoming d975ae9
Update heading notation in style guide, add a section to suggest what…
benjaoming e582cc8
Merge branch 'styleguide-updates' of github.com:benjaoming/readthedoc…
benjaoming 9181f0c
Use cross-references to exemplify..... cross-references!
benjaoming b7e3827
Add proposal for using "Git provider"
benjaoming 9a27fc9
Add substitutions subsection
benjaoming 8733c34
Not dash, make it a sentence (otherwise we can use a definition list)
benjaoming 2bc794e
Add git providers substitution pattern (correcting PGP sig)
benjaoming 273abf7
Fix a typo - when=>then
benjaoming b913829
Apply suggestions from code review @ericholscher
benjaoming 8060351
Add section "Differentiating .org and .com" from @humitos' request
benjaoming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking
$variable
to differentiate them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! So on that note, would you prefer
$variable
and that the example ishttps://$slug.readthedocs.io
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the sh interpolation syntax is nice as it give variable boundaries:
https://${slug}.readthedocs.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I prefer just one notation and that it's
<variable name>
and<abstract concept>
. It's because I have a hard time coming up with examples from our documentation of referenced variable names that are 100% bound and not actually also an abstract concept that we introduced in the docs.So even if we say
https://$slug.readthedocs.io
orhttps://${slug}.readthedocs.io
, there actually doesn't exist a real variable calledslug
but just a concept from the text. So this might as well be<slug>
and no distinction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that seems reasonable, especially since we're using
$
variables to actually be explicit vars in places in the application (eg;.$rest
in redirects). So probably better to preserve them for that.