Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: Split Subprojects in Explanation and How-to (Diátaxis) #9785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Split Subprojects in Explanation and How-to (Diátaxis) #9785
Changes from 23 commits
fe1834d
98405ef
b5a0b28
dcfd850
a7f620b
51f0b65
06d66bf
88539ab
91b6093
7d646ff
671268d
6ec729e
9c558ba
36d1518
be54e81
b2f15c8
0e60438
e2152f6
5ccd208
56ab513
87dc2cd
4bff449
b08f8ba
0abc008
29b9006
f7cbdb7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: @humitos comment about HowTo's, screenshots also don't match across .com & .org currently. It will be better once we ship the new templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, maybe with tabbed panels, we can find a clever way to fix this in the future.
It's okay to stick with .org screenshots for now, right? Pretty sure that's the general pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not emphasize a negated sentence, since it communicates a warning or the inability to undo the step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A rephrase may work better for emphasize:
**Deleting a subproject only removes the reference from the main project.** It does not completely remove that project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is hard to read for me. I'm not sure if "can be made available" is what confuses me, there is a word missing or something else 🙃 --maybe I'm just tired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix it -- being tired is a good benchmark for readability 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea,
can be made available
is super passive voice.Is activated
or similar would be active voice.