Skip to content

Docs: Refactor downloadable docs #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 6, 2022
Merged

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 30, 2022

Refs #9746
Closes #9577


📚 Documentation previews 📚

@ericholscher ericholscher requested a review from a team as a code owner November 30, 2022 03:49
@ericholscher ericholscher changed the base branch from main to diataxis/main November 30, 2022 03:49
@ericholscher ericholscher changed the title downloadable docs Refactor downloadable docs Nov 30, 2022
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When splitting content into explanation and how-to, shouldn't we link them each other somehow? I mean, as a user, after reading the explanation and I will be excited about offline formats and I'd want to know how to enable the in my project.

It works in the other direction too, I guess. Arriving at the "how-to" without knowing exactly what they are, I may be lost. So, a link back to the explanation in the first or second paragraph could work great here.

@humitos
Copy link
Member

humitos commented Nov 30, 2022

When splitting content into explanation and how-to, shouldn't we link them each other somehow? I mean, as a user, after reading the explanation and I will be excited about offline formats and I'd want to know how to enable the in my project.

I think this can be standardized in a simple way to start. Maybe just a .. seealso:: with some bullets and links at the end of the pages?

.. seealso::

  * :doc:`downloadable-documentation`

@benjaoming
Copy link
Contributor

benjaoming commented Nov 30, 2022

@humitos yup, definitely, we also used seealso:: in other Diátaxis refactors, although the text has varied a bit. I don't think we're far from arriving at some kind of template. I'm trying to compile generic inputs here: https://docs.google.com/document/d/1Ir8UvupznvAH4oF4-DEiXrILnEk2Lqsg4FrPDA-8uXA/edit#

@ericholscher
Copy link
Member Author

ericholscher commented Nov 30, 2022

@humitos yup, definitely, we also used seealso:: in other Diátaxis refactors, although the text has varied a bit. I don't think we're far from arriving at some kind of template. I'm trying to compile generic inputs here: https://docs.google.com/document/d/1Ir8UvupznvAH4oF4-DEiXrILnEk2Lqsg4FrPDA-8uXA/edit#

Strong agree on the seealso, I just ran out of energy last night when working on it 😆

@ericholscher
Copy link
Member Author

Updates are ready for review 👍

@ericholscher
Copy link
Member Author

@benjaoming Would love a review on this soon, so we can get it merged.

@benjaoming benjaoming requested review from a team as code owners December 6, 2022 15:18
@benjaoming benjaoming requested a review from agjohnson December 6, 2022 15:18
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sync'ed branches, which worked fine.

Have just the one suggestion above to add some kind of explanation about the role of the documentation framework.

Otherwise, looks great, really nice to get started with this, as there are many additional things in the horizon. Noticing both custom build processes, but also suggestions to add DocSets support 👍

@ericholscher ericholscher merged commit 6435054 into diataxis/main Dec 6, 2022
@ericholscher ericholscher deleted the downloadable-docs branch December 6, 2022 22:38
@benjaoming benjaoming changed the title Refactor downloadable docs Docs: Refactor downloadable docs Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants