-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Docs: cancel PR builds if there is no documentation changes #9734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use the new feature to cancel builds if there are not documentation changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We should also be running this ASAP in production to make sure that we gather maximum hands-on experience with the approach :)
@humitos we'll have to investigate why the latest build fails with exit code 1: https://readthedocs.org/projects/dev/builds/18636879/ |
a22d8dd
to
66a78c6
Compare
Meh, this doesn't work as we expected. When |
We don't have to exit the command immediately when `git diff` exists with 1; that means there are changes and we want to continue building the documentation.
If you want the one-liner, you can use |
I don't think that works either. Have you tested it? |
Cool! I figured it out. My last command change worked! 💪🏼 |
Yes, worked fine locally 👍 |
Co-authored-by: Benjamin Balder Bach <[email protected]>
Since this does change |
Use the new feature to cancel builds if there are not documentation changes