-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add an initial policy for delisting unmaintained projects #9731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not 100% in love with this content structure, but I think it's important to get this out. Closes #9130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the first part, most of the comments are in the same genre. But looks like we can get this cleared quickly, would be great for the quality of contents served via RTD to have a policy that does exactly what this policy does 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good start.
It's not clear to me if this policy will be applied automatically or only by project owners' requests. I'm assuming the later, but I'd be good to be explicit in the document. My confusion arises because of the "Delisting of an abandoned project" made me think it will be automatic (or without anybody requesting it)
Co-authored-by: Manuel Kaufmann <[email protected]> Co-authored-by: Anthony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting close, but the last section still feels muddled to me. This doesn't need to be a legal document, we want to ensure we're communicating what the requirements are, and the actions we take clearly.
docs/user/unofficial-projects.rst
Outdated
Disallow: / | ||
|
||
|
||
Projects will be delisted if they meet *all* of the following criteria: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using all here instead of ALL, like above. We should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, I changed this to be bold text in another section because using caps for emphasis is an a11y pattern to avoid, generally speaking. Capital letters can affect screen reader usage (some will output this as an acronym, not read it as a word) and all caps can negatively affect readers with dyslexia.
If we're looking for emphasis, we have native options in reST like bold, italic, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, changing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "core" looks good to me. I commented about some details that can be improved.
Co-authored-by: Manuel Kaufmann <[email protected]> Co-authored-by: Eric Holscher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty happy to ✅ this PR after going back and forth for days! Great work @benjaoming 💯
@ericholscher I guess it can be up to you to review or merge this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good with my suggested change 👍
Co-authored-by: Eric Holscher <[email protected]>
I do think we also need to address somehow the difference between our abandoned project policy & this one. Otherwise it will be confusing for users. |
@ericholscher in later Diátaxis documentation refactors, a top-level "Policy" item is added under Reference. Perhaps this level can help to explain differences between policies. In addition, cross-references might also look good here. Such as adding a tip, "projects may be official but still unmaintained, in this case please see Abandoned Projects Policy". |
Added ⬆️ as a note for Iteration 2. |
IMO, the difference with the abandoned policy is that in the abandoned one "the requester wants to take ownership of the slug" (e.g. to update the docs or to use it for another project's docs) and in this one that's not the case |
Yea, we just need to make that clear to them :) |
Added two cross-references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I suggested to update the texts to be more direct.
Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Manuel Kaufmann <[email protected]>
I think we're 👍 to merge this. This also does remind me that we aren't currently removing abandoned projects from search results, but we probably should do that too? Edit: I guess we can just apply both policies to the project! So once we reach out about the abandoned project, we can also mention the delisting. 🤔 |
@ericholscher agreed, policy is good to go 💯
This might be hard to remember. I made note of it in my own notes about Abandoned projects. But I can see the entrypoint for a report on a project being either of the policies, so all policy processing could potentially have an additional generic item for the core team member "Check if this project needs action in relation to other of our policies". |
I'm not 100% in love with this content structure,
but I think it's important to get this out.
Closes #9130
📚 Documentation previews 📚
docs
): https://docs--9731.org.readthedocs.build/en/9731/dev
): https://dev--9731.org.readthedocs.build/en/9731/