Proxito: refactor doc serving #9726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
refactor-file-serve
branch
2 times, most recently
from
9f5061e to
a250642
Compare
stsewd
force-pushed
the
refactor-file-serve
branch
from
a250642 to
d7f6155
Compare
humitos
reviewed
Nov 30, 2022
There was a problem hiding this comment.
This is really good! 💯
I understand that there weren't logic changes here and most of it is moving code from one place to another. So, I didn't go too deep into reviewing the logic and everything. I trust on our test suite and in you 😄
I left some comments that will improve the reading of this code next time we have to deal with it and also ideas to apply some simplifications. Let me know what you think about them.
Comment on lines
117
to
119
| Serve from the filesystem if using ``PYTHON_MEDIA``. We definitely | ||
| shouldn't do this in production, but I don't want to force a check for | ||
| ``DEBUG``. |
There was a problem hiding this comment.
We should probably kill PYTHON_MEDIA now that we have all the set ups using Docker with NGINX 😄
humitos
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so it's easier to share this code with the new implementation.
_serve_filemethod, to serve any file from storage, and 3 high level methods to serve files from docs, static files, or downloads.